ouroboros, branch testing

ipcpd: Fully gate fa/dt RIB ops on IPCP_FLOW_STATS

2026-05-27T13:55:08+00:00

The previous shape registered no-op _rib_read / _rib_readdir / _rib_getattr handlers when IPCP_FLOW_STATS was off, and there was a bug where *buf was not set in the no-op causing free on an uninitialized pointer. IPCP_FLOW_STATS was referenced by config.h.in but the declaration was lost during the CMake refactor. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Drain mainloop before component shutdown

2026-05-27T13:55:08+00:00

Worker mid fa_dealloc could still try to read from fa.psched because stop_components() ran before ipcp_stop()/tpm_stop(). Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Close dt stat_used race vs rib readdir

2026-05-27T13:55:08+00:00

The stat_used function updated dt.stat[fd].stamp under the per-stat mutex, released it, then took dt.lock wrlock to bump dt.n_flows. A concurrent dt_rib_readdir holding dt.lock rdlock between those two critical sections saw the new stamp but the old n_flows. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

irmd: Reorder init/fini

2026-05-27T13:55:08+00:00

Application-level OpenSSL objects (X509_STORE held by irm/OAP) must be released before OPENSSL_cleanup() tears down libcrypto's globals, otherwise their destructors run against half-finalised state. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

ipcpd: Fix eth double-release in MGMT rx path

2026-05-27T13:55:08+00:00

The MGMT-frame branch in eth_ipcp_packet_reader releases the spb at the top of the loop iteration; two error exits released a second time. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Fix mixed declarations in hash.c

2026-05-27T13:54:57+00:00

The contexts are not declared at the top of the function anymore after addition of the CRC8/CRC16 variants (no implementation in libgcrypt). Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Add FIN and receive-side linger for msg dealloc

2026-05-22T06:13:50+00:00

qos_msg flows had no end-of-stream signal: a deallocating sender relied on the peer's inactivity timers (~30 s) to notice. Worse, the dealloc-linger path was bugged: a receiver that called flow_dealloc would stop draining its rx_rb while the peer's tail retransmits kept arriving. Peer retransmitted into a black hole until its own dealloc fired, and the whole shutdown stretched takes t_a time. Generalizes frcti_stream_fin_snd to frcti_fin_snd; for msg mode emit a FRCT_FIN-only control packet with the FIN seqno boundary in pci->ackno. Receiver-side frcti_rcv latches rcv_fin_seen and stores the boundary on FRCT_FIN-without-DATA. Fix comment on the FRCT flags. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Allow up to two TLPs per recovery episode

2026-05-22T06:13:50+00:00

RFC 8985 §7.3 permits up to two tail loss probes before falling back to RTO. Previously FRCP allowed exactly one TLP per episode, making tail-loss recovery dependent on a successful first probe; if that probe was lost the sender fell straight to slow RTO with exponential backoff. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders

lib: Further align FRCP with TCP RFCs

2026-05-22T06:13:50+00:00

Only the HoL slot retransmits on RTO; non-HoL slots defer and rely on SACK/RACK fast-rxm for recovery. Matches RFC 6298 §5.4 + RFC 8985 §3 and Linux tcp_retransmit_skb(head, 1). Eliminates the spurious-RTO storm where ~50-66% of retransmits arrived as duplicates at the peer. Co-fixes for three latent state-machine bugs that the previous spurious-retx mask was hiding: - recovery_enter: seal recovery_high at the false→true edge only (RFC 6582 §3.2). Previously extended on every gap-SACK, which trapped the sender in NewReno indefinitely once any cum-ACK fell behind the moving recovery_high. - rtt_sample_eligible: drop the in_recovery super-gate. Karn at the per-slot SND_RTX|SND_TLP level is already correct (matches Linux). - rxm_due defer interval: use base RTO, not rto< Signed-off-by: Sander Vrijders

lib: Set a timeout on FRCT control packets

2026-05-22T06:13:50+00:00

Time out frct_tx for control packets at 250us so a full tx ring cannot stall the timer wheel (and with it KA, TLP, RXM fires). DATA frames (fresh, RXM, TLP, FIN) keep blocking - dropping them would lose recovery progress. Add inact_drop, drf_rebase, rq_released, tlp_snd, sdu_snd_alloc, sdu_snd_tx, sdu_sole, rxm_tx_dead, and per-type tx_drop counters. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders