From a5ab03c956dce6df3148bb2df0cf8f5cf759f28a Mon Sep 17 00:00:00 2001 From: Dimitri Staessens Date: Mon, 25 May 2026 14:50:30 +0200 Subject: ipcpd: Fix eth double-release in MGMT rx path The MGMT-frame branch in eth_ipcp_packet_reader releases the spb at the top of the loop iteration; two error exits released a second time. Signed-off-by: Dimitri Staessens Signed-off-by: Sander Vrijders --- src/ipcpd/eth/eth.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'src') diff --git a/src/ipcpd/eth/eth.c b/src/ipcpd/eth/eth.c index 103ba881..d6f476f2 100644 --- a/src/ipcpd/eth/eth.c +++ b/src/ipcpd/eth/eth.c @@ -1298,13 +1298,13 @@ static void * eth_ipcp_packet_reader(void * o) if (length > MGMT_FRAME_SIZE) { log_warn("Management frame size %u exceeds %u.", length, MGMT_FRAME_SIZE); - goto fail_frame; + continue; } frame = malloc(sizeof(*frame)); if (frame == NULL) { log_err("Failed to allocate frame."); - goto fail_frame; + continue; } memcpy(frame->buf, &e_frame->payload, length); -- cgit v1.2.3